[mantisbt-dev] FW: [mantisbt] MantisBT Modern UI (#272)

[P Richards]

OK – I’ve marked this PR request as closed for now, as we need to have a discussion (as per our agreed policy that victor proposed IIRC) for two reasons:



1) “Adding or removing an external library should be discussed first on the developer mailing list.

The following must be considered when reviewing an external library

* Technical fit

* License compatibility

* Recent development activity

* Community size/support

Changing versions of a library does not need to be discussed, unless there are major changes in the review criteria, e.g. change of license“

2) There’s a lot of what appears to be Whitespace changes in the first commit – I’m thinking/guessing tab/spaces. There’s no point us doing a line-by-line review of each commit if the linefeeds/tabs have been incorrectly changes on the first file

As that approach will get really spammy. The PR needs to be discussed and fixed up first before we can start a review process.

Paul



From: Victor Boctor [mailto:***@github.com]
Sent: 17 August 2014 23:37
To: mantisbt/mantisbt
Cc: grangeway
Subject: Re: [mantisbt] MantisBT Modern UI (#272)

- # prefix data with u_
- $t_pref = user_pref_get( $p_user_id );
+ # prefix data with u_

Is this comment out of date?

—
Reply to this email directly or view it on GitHub <https://github.com/mantisbt/mantisbt/pull/272/files#r16332804> . <Loading Image...>

[P Richards]

Victor,



And regarding your point on the comment, in master, this comment is there, and is indeed invalid – there’s a Pull Request to remove it if you really want it gone @ https://github.com/mantisbt/mantisbt/pull/273



So fixing that isn’t really something related to ‘theming’/design of mantis




Paul



From: Victor Boctor [mailto:***@github.com]
Sent: 17 August 2014 23:37
To: mantisbt/mantisbt
Cc: grangeway
Subject: Re: [mantisbt] MantisBT Modern UI (#272)

- # prefix data with u_
- $t_pref = user_pref_get( $p_user_id );
+ # prefix data with u_

Is this comment out of date?

—
Reply to this email directly or view it on GitHub <https://github.com/mantisbt/mantisbt/pull/272/files#r16332804> . <https://github.com/notifications/beacon/434241__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyMzkzNDI0NiwiZGF0YSI6eyJpZCI6Mzk3NTUyMDJ9fQ==--6e9e577b4ed8f16ab9f49cc4518966c5fa25fc82.gif>