Roland Becker [mailto:roland@atrol= .de</a>] <br>
1970-01-01 00:00:00 UTC
Thanks,
-Victor
--------------------------------------------------------------------
----------
_______________________________________________
mantisbt-dev mailing list
mantisbt-***@lists.sourceforge.net<mailto:mantisbt-***@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
----------------------------------------------------------------------
-------- _______________________________________________
mantisbt-dev mailing list
mantisbt-***@lists.sourceforge.net<mailto:mantisbt-***@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
------------------------------------------------------------------------------
_______________________________________________
mantisbt-dev mailing list
mantisbt-***@lists.sourceforge.net<mailto:mantisbt-***@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--_000_39361452A03A402A83E6FF5459B15BFFmantishubnet_
Content-Type: text/html; charset="Windows-1252"
Content-ID: <***@namprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div>With respect to Bootstrap vs. other frameworks:</div>
<div><br>
</div>
<div>There are a couple of popular web frameworks: Bootstrap & Foundation</div>
<div><br>
</div>
<div>+ If you scan both <a href="http://getbootstrap.com/getting-started/">bootstrap</a> & <a href="http://foundation.zurb.com/docs/">foundation</a> docs, you will see the same features, similar markup and same web components. </div>
<div><br>
</div>
<div>+ Bootstrap has a much bigger ecosystem. It came first and was backed by twitter. It captured developers mindshare early on and became the de-facto standard web framework as these recent stats show:</div>
<div><a href="http://techcrunch.com/2013/07/28/bootstrap-3-goes-mobile-first-now-reportedly-powers-1-of-the-web/">http://techcrunch.com/2013/07/28/bootstrap-3-goes-mobile-first-now-reportedly-powers-1-of-the-web/</a></div>
<div><a href="http://blog.meanpath.com/4-7m-sites-using-bootstrap-vs-334k-on-foundation/">http://blog.meanpath.com/4-7m-sites-using-bootstrap-vs-334k-on-foundation/</a></div>
<div><br>
</div>
<div>As such, bootstrap has the lion share of docs, plugins, free and commercial themes (like the one used with Mantis) … etc </div>
<div><br>
</div>
<div>+ Other than that, it is hard to differentiate between both frameworks. Here are couple of different opinions to chew on:</div>
<div><a href="https://medium.com/@felippenardi/top-5-core-differences-between-bootstrap-3-and-foundation-5-8b3812c7007c">https://medium.com/@felippenardi/top-5-core-differences-between-bootstrap-3-and-foundation-5-8b3812c7007c</a></div>
<div><a href="http://blog.teamtreehouse.com/use-bootstrap-or-foundation">http://blog.teamtreehouse.com/use-bootstrap-or-foundation</a></div>
<div><br>
</div>
<div><br>
</div>
<div>What about JQuery Mobile?</div>
<div>It is a great framework for building mobile user interfaces. I started using it when it was in early alpha and was a big fan. That’s until Bootstrap v3.0 came along. Bootstrap v3 is far superior framework for building responsive interfaces that works on
desktop, tablet and mobile.</div>
<div><br>
</div>
<div><br>
</div>
<div>What about Theme Roller?</div>
<div>That’s not a framework. It is a feature available in <a href="http://jqueryui.com/themeroller/">jqueryui.com</a> to allow users to customize the look and feel of jqueryui components. The output of the theme roller is a custom css file to apply alongside
the core jqueryui library. If you want the same for mantis, you need to build it. It won’t matter if the underlying framework is Bootstrap or Foundation. </div>
<div><br>
</div>
<div> </div>
<div><br>
</div>
<div>
<blockquote type="cite">So far, the works been done by someone that has never done a commit to mantis before </blockquote>
</div>
<div><br>
</div>
<div>There is always a first time</div>
<div><br>
</div>
<div><br>
</div>
<div>
<blockquote type="cite">The new layout would look great for a service (like mantis hub),</blockquote>
<br>
</div>
<div>Nothing in this work was customized for MantisHub. </div>
<div>The sidebar design is increasingly popular choice (Github, Jira, BitBucket) because of the popularity of widescreen monitors. With widescreen, you have more horizontal space to work with and less vertical space. Using vertical space to show a navigation
menu with 5 links is just a waste of precious user work area.</div> <div><br> </div> <div><br> </div> <div>-Rafik </div> <div><br> </div> <br> <div> <div>On Aug 18, 2014, at 1:33 PM, P Richards <<a href="mailto:***@mantisforge.org">***@mantisforge.org</a>> wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">My main concern is that we evaluate options properly - any decision we take now is something that the whole dev-team and any plugin author will be using.
<br>
<br>
So far, the works been done by someone that has never done a commit to mantis before - whilst it's fairly clear that they are not stupid, at the same time, there's historical decisions and historical roadmap items and plans etc that may not have been considered.
It may be that after this work, we never see the author again. Our published contribution guidelines state to talk to the dev list first etc etc etc.<br>
<br>
Hopefully Rafik will submit a PR with whitespace tidied up and splitting out some of the non-design changes (i.e. jquery) so we can actually have a proper look at the work, but there's decisions in that PR that we've already discussed and decided on a path
'for now'.<br>
<br>
For example,<br>
<br>
In october 2013 Victor send a mail about upgrading JQuery from 1.7.2 to 1.9 or 2.0<br>
Robert replied stating that moving to 2.0 would rule out IE8<br>
Etc<br>
I replied with what I deemed a favourite question: "what browsers do *we support*? :)"<br>
A Mantis user replied to the converstation stating about being careful about browser support as they only have IE8<br>
Robert replied stating IE8 is here to stay.<br>
<br>
I might have got the order slightly wrong in the above, but the end outcome I believe was we updated master from jquery 1.7.2 to 1.9.1<br>
<br>
If I google for "IE market share" - the first hit I get is <a href="http://www.netmarketshare.com/browser-market-share.aspx?qprid=2&qpcustomd=0">
http://www.netmarketshare.com/browser-market-share.aspx?qprid=2&qpcustomd=0</a>, which states IE8 as having 22% share (not sure how they generate these stats as that seems nut ;)) IF I go for the 2nd hit (<a href="http://www.w3counter.com/globalstats.php">http://www.w3counter.com/globalstats.php</a>),
that shows chrome with 20% etc, IE9 6.5%, IE11 5.6%, and IE8 4%<br>
<br>
My understanding is bootstrap 3 would support IE 8 for *most* things, and that jquery 2.x does not support IE8 - hence my point about breaking the PR up a bit, and also it needing to have a discussion.<br>
<br>
The other part is ensuring that we map design changes to something that is flexible for as many existing users to use and fit into their existing setup as possible. The new layout would look great for a service (like mantishub), it may not look as good for
people that are trying to top/tail it to use it in existing environments. We need to ensure that our approach provides flexibility for both - this is something that mantis arguably does well for other things due to our complexity of configuration options.<br>
<br>
Paul<br>
<br>
<br>
<br>
-----Original Message-----<br>
From: Roland Becker [<a href="mailto:***@atrol.de">mailto:***@atrol.de</a>]
<br>
Sent: 18 August 2014 21:01<br>
To: developer discussions; Paul Richards<br>
Subject: Re: [mantisbt-dev] Introducing MantisBT Modern UI<br>
<br>
Paul,<br>
<br>
it seems your main concern is using Bootstrap<br>
<br>
<blockquote type="cite">We set a policy in january that before we accept any external library
<br>
changes etc, we need to have a discussion on the mailing list.<br>
And that’s aside from the fact that we need to have a discussion <br>
around whether to use bootstrap.<br>
</blockquote>
<br>
Let's start the discussion and get a decision: Use Bootstrap or not.<br>
<br>
I can't contribute that much to this decision as I have no own experience using Bootstrap or any other comparable component.<br>
I don't want to vote just because I read a few articles and comparisons about it.<br>
<br>
What I noticed is a big amount of transferred CSS and JavaScript compared to the current version. (about additional 700KB when opening for the first time, but also more traffic for following requests)<br>
<br>
Are there any known issues using Bootstrap?<br>
<br>
Roland<br> <br> <blockquote type="cite">Paul Richards <<a href="mailto:***@mantisforge.org">***@mantisforge.org</a>> hat am 18. August 2014 um 09:16<br>
geschrieben:<br>
<br>
<br>
On 18 Aug 2014, at 01:00, Victor Boctor <<a href="mailto:***@gmail.com">***@gmail.com</a>> wrote:<br>
<br>
Paul,<br>
<br>
On Aug 17, 2014, at 2:23 AM, P Richards <<a href="mailto:***@mantisforge.org">***@mantisforge.org</a>> wrote:<br>
<br>
Rafiq,<br>
<br>
As i’ve seen on the PR, and when you originally said you were looking <br>
at this a month ago, and asked you to mail the Mailing List, we need <br>
to have a discussion about the design and the approach.<br>
<br>
<br>
[Victor] Correct. The request from you when Rafik sent out a preview <br>
was to publish the code and the discussion to the DL, which he just <br>
did. Your words were that even though the decision to use bootstrap <br>
is likely to be a short discussion, it is worth having anything.<br>
<br>
<br>
[Victor] The bootstrap decision really started when the website was <br>
developed. At this time, bootstrap was used and the request by the <br>
team from the Rafik was to do the same modernization to MantisBT. <br>
Hence, he started doing the work. As for plugins, they are typically <br>
easy to adapt to whatever framework MantisBT is using.<br>
<br>
<br>
Actually, I said we should have a be having a discussion on the <br>
mailing list and before writing code:<br>
<br>
"Whilst I suspect that is probably a good choice, we should have been <br>
having a discussion on whether bootstrap is the way to go with Mantis <br>
or something else before writing any code.”<br>
<br>
We set a policy in january that before we accept any external library <br>
changes etc, we need to have a discussion on the mailing list.<br>
<br>
And sorry, the website was something that was also done without <br>
discussion initially - so that’s not really a valid point. The website <br>
has always been a separate code base to Mantis.<br>
<br>
<br>
One of the main requests from users in the past, is that users want <br>
slightly different thing’s - i.e. people want to be able to customise <br>
the look and feel of mantis in different ways.<br>
<br>
<br>
[Victor] I’m not personally in favor of too much customization to the UI.<br>
In my opinion, a lot of the users that heavilty themed Mantis in the <br>
past were motivated to improve the look. However, what we really need <br>
to focus on is the ability for users to continue to be able to extend <br>
MantisBT via plugins. If we get into theming, we can support color <br>
shade (e.g. green template, blue template, etc) rather than complete <br>
customization. Complete customization adds little value and can <br>
significantly increase complexity of code and test matrix. I believe <br>
users evaluate MantisBT evalute it based on functionalty, look, and <br>
extensions to fill gaps that we don’t have in core or integrate their own custom functionality.<br>
<br>
<br>
We’ve had a lot of questions over the years to allow alteration of <br>
bits of Mantis. What we’ve always done is been flexible with the <br>
approach - hence the fact today we have configuration variables for everything.<br>
<br>
If you consider the design of Mantis and the number of pages, we have <br>
7 main things users use / want to customise:<br>
<br>
a) header<br>
b) menu bar<br>
b) page content -> view issue<br>
c) page content -> view issues<br>
d) page content -> report issue<br>
e) page content -> my view page<br>
f) footer<br>
<br>
When people have gone in the past “it should be possible to <br>
template/theme whole of mantis’, personally - I can’t see people doing <br>
that, or it being sustainable for us.<br>
<br>
However, I can see companies that want to brand mantis replacing A+F <br>
in the list above, and potentially B<br>
<br>
In terms of B/C/D/E - I suspect you would not touch the design of C/E, <br>
but the ability to tweak B+D is where most drivers come from.<br>
<br>
For example, I scrapped the report issues page at work a long term ago <br>
as it was not suitable for non-technical users. And within Mantis at <br>
the time, the flexibility we provide for customising it does not <br>
exist. This is actually one block of Mantis where i’d agree with the <br>
people wanting support for templates.<br>
<br>
View Issue I didn’t touch as it’s mainly technical staff that use it, <br>
however if the ability existed to template it properly, would be tweaked.<br>
<br>
<br>
<br>
<br>
In it’s current form, this PR isn’t suitable for this - For example - <br>
whilst it’s nicer, the reason I use mantis is due to the way it can be <br>
integrated into other systems - so the side bar is a no go.<br>
<br>
<br>
[Victor] I’m not sure what you mean by integrating MantisBT in other <br>
systems and why the side bar blocks that?<br>
<br>
<br>
Mantis has always been a top down design - if you replace the <br>
header/footer you can embed the remaining content within another page, <br>
leaving the menu at the top for navigation.<br>
<br>
<br>
<br>
For most end users, Mantis consists of 4 pages:<br>
<br>
1) My View Page<br>
2) View Issues Page<br>
3) Report Issues Page<br>
4) View Issue Page<br>
<br>
I think we can do a better job then the current theme if we focus on <br>
looking at the design and the ability to customise these 4 pages.<br>
<br>
<br>
For example, in a modern system, the “My View” page I would have <br>
expect to be a ajax dashboard.<br>
<br>
<br>
I sent an email a few weeks ago now for feedback on using DataTables <br>
to ajaxify the View Issues list.<br>
<br>
<br>
<br>
[Victor] This is just a scoping exercise. The first iteration’s goal <br>
is to improve the look and use a more modern code styling. Once this <br>
is in, we can follow up by enriching specific page to make it use <br>
ajax. Good examples are “My View” and filter page. Once Rafik’s <br>
change is checked in, we can all collaborate on enriching specific pages as necessary.<br>
<br>
For 3/4, the requests tend to be to allow fields to be re-ordered, <br>
turned on/off.<br>
<br>
At the moment, the work doesn’t help any of these requests from users.<br>
<br>
<br>
[Victor] Agreed on these features, but think of Rafik’s change as a <br>
foundation work for these features. I don’t see how there is a <br>
conflict between these features and styling of pages.<br>
<br>
Whilst I did try to have a look at the Pull Request, there seems to be <br>
a number of Whitespace changes, and non-theme/design changes that make <br>
it impossible to review the patches.<br>
<br>
<br>
[Victor] I agree that the change has some white spacing issues that <br>
cause more changes than actually needed. Maybe Rafik can explore of <br>
this issue can be fixed with reasonable effort.<br>
<br>
Back in January, we agreed as a Team to get 1.3 shipped, and then look <br>
at UI and email notifications changes. Victor knows I’ve got some work <br>
on templating emails and pages within Mantis from back then, which I <br>
said I’d get a PR up for once the Database changes had been done - <br>
which we agreed as a team to do immediately after 1.3. So until we’ve <br>
done this, compared the two approaches and decide which route we want <br>
to go, i’m strongly against this getting merged.<br>
<br>
<br>
[Victor] Here is a case where you also have gone and implemented some <br>
change without discussion with the team. At that point I had <br>
discussed email templating (not UI tempting) and proposed an approach, <br>
some previews, and you complained and stopped the work. I’ve asked <br>
you then to share your code / approach and you haven’t. You just <br>
killed the momentum and said that you will publish your code by end of <br>
January then after 1.3. At that point we also agreed that code that <br>
is not published doesn’t exist and can’t be used to block other work. <br>
Rafik has shared a preview of this work with the team 1-2 month ago <br>
and everyone except you on the core team was excited and gave him UI <br>
level feedback which he addressed. So, I expect this code to be <br>
merged. The discussion is when exactly it is going to be merged based on the 1.3 plan.<br>
<br>
<br>
We agreed to ship 1.3 first so…<br>
<br>
When rafiq shared a preview with people 1-2 months ago was when i <br>
jumped in immediately and said:<br>
a) we should be discussing this on the dev list.<br>
b) we need to have a discussion on whether to go with bootstrap.<br>
c) I believe I said in the same post, we need to have a discussion on <br>
sidebar on the dev list.<br>
<br>
It’s really disappointing actually for me that Rafik has refused for 2 <br>
months to email the development list as it’s not enabled a discussion <br>
to take place properly. I think I said in the same email that I quite <br>
liked the design.<br>
<br>
Rafik is someone that’s never contributed to Mantis before, has never <br>
been introduced to us apart from dumping a website re-design and now <br>
has added a<br>
10,000 line commit, which is basically impossible to review.<br>
<br>
My purpose for asking him to communicate with the development list 2 <br>
months ago was so that we could have a discussion at an EARLY stage.<br>
<br>
As it is, until we get a PR that doesn’t contain X000 lines of <br>
incorrect whitespace changes in the first commit, it’s actually <br>
impossible to even attempt to review and look at what has been done. <br>
And that’s aside from the fact that we need to have a discussion around whether to use bootstrap.<br>
<br>
Paul<br>
<br>
<br>
On Mon, Aug 18, 2014 at 1:11 AM, Victor Boctor <<a href="mailto:***@gmail.com">***@gmail.com</a>> wrote:<br>
<br>
<blockquote type="cite">Paul,<br>
<br>
On Aug 17, 2014, at 2:23 AM, P Richards <<a href="mailto:***@mantisforge.org">***@mantisforge.org</a>> wrote:<br>
<br>
Alain,<br>
<br>
It’s even more painful, when it’s a big change, and changes the <br>
approach we go in Mantis - hasn’t been discussed on the mailing <br>
list, and there’s work in progress (well, on hold until after 1.3) <br>
to allow greater flexibility of theming mantis already. We agreed <br>
back in January to use the following approach regarding external libraries:<br>
<br>
<br>
[Victor] When Rafik contributed the new website in January, he was <br>
asked by several on the team to help out with doing the same for MantisBT itself.<br>
Hence, his contribution. He has used Bootstrap on the website and <br>
carried that forward to MantisBT itself. Given that he has followed <br>
through with this and put this hard word, I would expect that we <br>
would motivate him for that and appreciate the good work, rather than just being negative.<br>
<br>
Now, in terms of Rafiq’s work, I don’t necessarily see it as being a <br>
major problem (i.e. that we’ve got other work on theming) as I think <br>
it covers two different things - i.e. Rafiq’s trying to do a visual <br>
design, anything I’ve looked at tends to be working on allowing <br>
flexibility/functionality rather then visual effects, so the two probably go together in the end.<br>
<br>
<br>
[Victor] Exactly, the visual design is orthogonal to allows users to <br>
extend MantisBT through plugins. The believe Rafik’s suggested <br>
change was focused on revamping the visual design for all features. <br>
But to scope the change, it doesn’t try to go further than that. <br>
Once it is in, we can add more flexibility and modernize further.<br>
<br>
My main issue is we have plugin’s that add functionality, there’s <br>
multiple CSS frameworks out there now - Jquery UI, foundation, <br>
bootstrap etc, that we do need to consider our approach within <br>
Mantis. I’m pretty confident we could make a similar style using <br>
query ui, foundation or bootstrap - without two much work, so we need to decide what works best long term.<br>
<br>
<br>
[Victor] Bootstrap is a very popular and respected library. I think <br>
given that we have this used in the website and the proposed pull <br>
request now, I don’t see why we would go for something else. <br>
Bootstrap also provides a good story for responive design allowing <br>
us to have great native support for phones over time.<br>
<br>
The reason I started looking at using Jquery UI in the past (we <br>
actually moved the Jquery UI javascript from a plugin to the Mantis <br>
Core) was due to it being used by some plugins, and having the <br>
visual theme roller - which struck me as something that would allow <br>
an end user without HTML or CSS experience to brand Mantis into <br>
their company colours without very much work. Given that Mantis has <br>
found a whole bunch of uses - for both software development and <br>
non-software development workflows, this struck me originally as an easy win for end users and plugin author’s for styling.<br>
<br>
<br>
[Victor]
-Victor
--------------------------------------------------------------------
----------
_______________________________________________
mantisbt-dev mailing list
mantisbt-***@lists.sourceforge.net<mailto:mantisbt-***@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
----------------------------------------------------------------------
-------- _______________________________________________
mantisbt-dev mailing list
mantisbt-***@lists.sourceforge.net<mailto:mantisbt-***@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
------------------------------------------------------------------------------
_______________________________________________
mantisbt-dev mailing list
mantisbt-***@lists.sourceforge.net<mailto:mantisbt-***@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--_000_39361452A03A402A83E6FF5459B15BFFmantishubnet_
Content-Type: text/html; charset="Windows-1252"
Content-ID: <***@namprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div>With respect to Bootstrap vs. other frameworks:</div>
<div><br>
</div>
<div>There are a couple of popular web frameworks: Bootstrap & Foundation</div>
<div><br>
</div>
<div>+ If you scan both <a href="http://getbootstrap.com/getting-started/">bootstrap</a> & <a href="http://foundation.zurb.com/docs/">foundation</a> docs, you will see the same features, similar markup and same web components. </div>
<div><br>
</div>
<div>+ Bootstrap has a much bigger ecosystem. It came first and was backed by twitter. It captured developers mindshare early on and became the de-facto standard web framework as these recent stats show:</div>
<div><a href="http://techcrunch.com/2013/07/28/bootstrap-3-goes-mobile-first-now-reportedly-powers-1-of-the-web/">http://techcrunch.com/2013/07/28/bootstrap-3-goes-mobile-first-now-reportedly-powers-1-of-the-web/</a></div>
<div><a href="http://blog.meanpath.com/4-7m-sites-using-bootstrap-vs-334k-on-foundation/">http://blog.meanpath.com/4-7m-sites-using-bootstrap-vs-334k-on-foundation/</a></div>
<div><br>
</div>
<div>As such, bootstrap has the lion share of docs, plugins, free and commercial themes (like the one used with Mantis) … etc </div>
<div><br>
</div>
<div>+ Other than that, it is hard to differentiate between both frameworks. Here are couple of different opinions to chew on:</div>
<div><a href="https://medium.com/@felippenardi/top-5-core-differences-between-bootstrap-3-and-foundation-5-8b3812c7007c">https://medium.com/@felippenardi/top-5-core-differences-between-bootstrap-3-and-foundation-5-8b3812c7007c</a></div>
<div><a href="http://blog.teamtreehouse.com/use-bootstrap-or-foundation">http://blog.teamtreehouse.com/use-bootstrap-or-foundation</a></div>
<div><br>
</div>
<div><br>
</div>
<div>What about JQuery Mobile?</div>
<div>It is a great framework for building mobile user interfaces. I started using it when it was in early alpha and was a big fan. That’s until Bootstrap v3.0 came along. Bootstrap v3 is far superior framework for building responsive interfaces that works on
desktop, tablet and mobile.</div>
<div><br>
</div>
<div><br>
</div>
<div>What about Theme Roller?</div>
<div>That’s not a framework. It is a feature available in <a href="http://jqueryui.com/themeroller/">jqueryui.com</a> to allow users to customize the look and feel of jqueryui components. The output of the theme roller is a custom css file to apply alongside
the core jqueryui library. If you want the same for mantis, you need to build it. It won’t matter if the underlying framework is Bootstrap or Foundation. </div>
<div><br>
</div>
<div> </div>
<div><br>
</div>
<div>
<blockquote type="cite">So far, the works been done by someone that has never done a commit to mantis before </blockquote>
</div>
<div><br>
</div>
<div>There is always a first time</div>
<div><br>
</div>
<div><br>
</div>
<div>
<blockquote type="cite">The new layout would look great for a service (like mantis hub),</blockquote>
<br>
</div>
<div>Nothing in this work was customized for MantisHub. </div>
<div>The sidebar design is increasingly popular choice (Github, Jira, BitBucket) because of the popularity of widescreen monitors. With widescreen, you have more horizontal space to work with and less vertical space. Using vertical space to show a navigation
menu with 5 links is just a waste of precious user work area.</div> <div><br> </div> <div><br> </div> <div>-Rafik </div> <div><br> </div> <br> <div> <div>On Aug 18, 2014, at 1:33 PM, P Richards <<a href="mailto:***@mantisforge.org">***@mantisforge.org</a>> wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">My main concern is that we evaluate options properly - any decision we take now is something that the whole dev-team and any plugin author will be using.
<br>
<br>
So far, the works been done by someone that has never done a commit to mantis before - whilst it's fairly clear that they are not stupid, at the same time, there's historical decisions and historical roadmap items and plans etc that may not have been considered.
It may be that after this work, we never see the author again. Our published contribution guidelines state to talk to the dev list first etc etc etc.<br>
<br>
Hopefully Rafik will submit a PR with whitespace tidied up and splitting out some of the non-design changes (i.e. jquery) so we can actually have a proper look at the work, but there's decisions in that PR that we've already discussed and decided on a path
'for now'.<br>
<br>
For example,<br>
<br>
In october 2013 Victor send a mail about upgrading JQuery from 1.7.2 to 1.9 or 2.0<br>
Robert replied stating that moving to 2.0 would rule out IE8<br>
Etc<br>
I replied with what I deemed a favourite question: "what browsers do *we support*? :)"<br>
A Mantis user replied to the converstation stating about being careful about browser support as they only have IE8<br>
Robert replied stating IE8 is here to stay.<br>
<br>
I might have got the order slightly wrong in the above, but the end outcome I believe was we updated master from jquery 1.7.2 to 1.9.1<br>
<br>
If I google for "IE market share" - the first hit I get is <a href="http://www.netmarketshare.com/browser-market-share.aspx?qprid=2&qpcustomd=0">
http://www.netmarketshare.com/browser-market-share.aspx?qprid=2&qpcustomd=0</a>, which states IE8 as having 22% share (not sure how they generate these stats as that seems nut ;)) IF I go for the 2nd hit (<a href="http://www.w3counter.com/globalstats.php">http://www.w3counter.com/globalstats.php</a>),
that shows chrome with 20% etc, IE9 6.5%, IE11 5.6%, and IE8 4%<br>
<br>
My understanding is bootstrap 3 would support IE 8 for *most* things, and that jquery 2.x does not support IE8 - hence my point about breaking the PR up a bit, and also it needing to have a discussion.<br>
<br>
The other part is ensuring that we map design changes to something that is flexible for as many existing users to use and fit into their existing setup as possible. The new layout would look great for a service (like mantishub), it may not look as good for
people that are trying to top/tail it to use it in existing environments. We need to ensure that our approach provides flexibility for both - this is something that mantis arguably does well for other things due to our complexity of configuration options.<br>
<br>
Paul<br>
<br>
<br>
<br>
-----Original Message-----<br>
From: Roland Becker [<a href="mailto:***@atrol.de">mailto:***@atrol.de</a>]
<br>
Sent: 18 August 2014 21:01<br>
To: developer discussions; Paul Richards<br>
Subject: Re: [mantisbt-dev] Introducing MantisBT Modern UI<br>
<br>
Paul,<br>
<br>
it seems your main concern is using Bootstrap<br>
<br>
<blockquote type="cite">We set a policy in january that before we accept any external library
<br>
changes etc, we need to have a discussion on the mailing list.<br>
And that’s aside from the fact that we need to have a discussion <br>
around whether to use bootstrap.<br>
</blockquote>
<br>
Let's start the discussion and get a decision: Use Bootstrap or not.<br>
<br>
I can't contribute that much to this decision as I have no own experience using Bootstrap or any other comparable component.<br>
I don't want to vote just because I read a few articles and comparisons about it.<br>
<br>
What I noticed is a big amount of transferred CSS and JavaScript compared to the current version. (about additional 700KB when opening for the first time, but also more traffic for following requests)<br>
<br>
Are there any known issues using Bootstrap?<br>
<br>
Roland<br> <br> <blockquote type="cite">Paul Richards <<a href="mailto:***@mantisforge.org">***@mantisforge.org</a>> hat am 18. August 2014 um 09:16<br>
geschrieben:<br>
<br>
<br>
On 18 Aug 2014, at 01:00, Victor Boctor <<a href="mailto:***@gmail.com">***@gmail.com</a>> wrote:<br>
<br>
Paul,<br>
<br>
On Aug 17, 2014, at 2:23 AM, P Richards <<a href="mailto:***@mantisforge.org">***@mantisforge.org</a>> wrote:<br>
<br>
Rafiq,<br>
<br>
As i’ve seen on the PR, and when you originally said you were looking <br>
at this a month ago, and asked you to mail the Mailing List, we need <br>
to have a discussion about the design and the approach.<br>
<br>
<br>
[Victor] Correct. The request from you when Rafik sent out a preview <br>
was to publish the code and the discussion to the DL, which he just <br>
did. Your words were that even though the decision to use bootstrap <br>
is likely to be a short discussion, it is worth having anything.<br>
<br>
<br>
[Victor] The bootstrap decision really started when the website was <br>
developed. At this time, bootstrap was used and the request by the <br>
team from the Rafik was to do the same modernization to MantisBT. <br>
Hence, he started doing the work. As for plugins, they are typically <br>
easy to adapt to whatever framework MantisBT is using.<br>
<br>
<br>
Actually, I said we should have a be having a discussion on the <br>
mailing list and before writing code:<br>
<br>
"Whilst I suspect that is probably a good choice, we should have been <br>
having a discussion on whether bootstrap is the way to go with Mantis <br>
or something else before writing any code.”<br>
<br>
We set a policy in january that before we accept any external library <br>
changes etc, we need to have a discussion on the mailing list.<br>
<br>
And sorry, the website was something that was also done without <br>
discussion initially - so that’s not really a valid point. The website <br>
has always been a separate code base to Mantis.<br>
<br>
<br>
One of the main requests from users in the past, is that users want <br>
slightly different thing’s - i.e. people want to be able to customise <br>
the look and feel of mantis in different ways.<br>
<br>
<br>
[Victor] I’m not personally in favor of too much customization to the UI.<br>
In my opinion, a lot of the users that heavilty themed Mantis in the <br>
past were motivated to improve the look. However, what we really need <br>
to focus on is the ability for users to continue to be able to extend <br>
MantisBT via plugins. If we get into theming, we can support color <br>
shade (e.g. green template, blue template, etc) rather than complete <br>
customization. Complete customization adds little value and can <br>
significantly increase complexity of code and test matrix. I believe <br>
users evaluate MantisBT evalute it based on functionalty, look, and <br>
extensions to fill gaps that we don’t have in core or integrate their own custom functionality.<br>
<br>
<br>
We’ve had a lot of questions over the years to allow alteration of <br>
bits of Mantis. What we’ve always done is been flexible with the <br>
approach - hence the fact today we have configuration variables for everything.<br>
<br>
If you consider the design of Mantis and the number of pages, we have <br>
7 main things users use / want to customise:<br>
<br>
a) header<br>
b) menu bar<br>
b) page content -> view issue<br>
c) page content -> view issues<br>
d) page content -> report issue<br>
e) page content -> my view page<br>
f) footer<br>
<br>
When people have gone in the past “it should be possible to <br>
template/theme whole of mantis’, personally - I can’t see people doing <br>
that, or it being sustainable for us.<br>
<br>
However, I can see companies that want to brand mantis replacing A+F <br>
in the list above, and potentially B<br>
<br>
In terms of B/C/D/E - I suspect you would not touch the design of C/E, <br>
but the ability to tweak B+D is where most drivers come from.<br>
<br>
For example, I scrapped the report issues page at work a long term ago <br>
as it was not suitable for non-technical users. And within Mantis at <br>
the time, the flexibility we provide for customising it does not <br>
exist. This is actually one block of Mantis where i’d agree with the <br>
people wanting support for templates.<br>
<br>
View Issue I didn’t touch as it’s mainly technical staff that use it, <br>
however if the ability existed to template it properly, would be tweaked.<br>
<br>
<br>
<br>
<br>
In it’s current form, this PR isn’t suitable for this - For example - <br>
whilst it’s nicer, the reason I use mantis is due to the way it can be <br>
integrated into other systems - so the side bar is a no go.<br>
<br>
<br>
[Victor] I’m not sure what you mean by integrating MantisBT in other <br>
systems and why the side bar blocks that?<br>
<br>
<br>
Mantis has always been a top down design - if you replace the <br>
header/footer you can embed the remaining content within another page, <br>
leaving the menu at the top for navigation.<br>
<br>
<br>
<br>
For most end users, Mantis consists of 4 pages:<br>
<br>
1) My View Page<br>
2) View Issues Page<br>
3) Report Issues Page<br>
4) View Issue Page<br>
<br>
I think we can do a better job then the current theme if we focus on <br>
looking at the design and the ability to customise these 4 pages.<br>
<br>
<br>
For example, in a modern system, the “My View” page I would have <br>
expect to be a ajax dashboard.<br>
<br>
<br>
I sent an email a few weeks ago now for feedback on using DataTables <br>
to ajaxify the View Issues list.<br>
<br>
<br>
<br>
[Victor] This is just a scoping exercise. The first iteration’s goal <br>
is to improve the look and use a more modern code styling. Once this <br>
is in, we can follow up by enriching specific page to make it use <br>
ajax. Good examples are “My View” and filter page. Once Rafik’s <br>
change is checked in, we can all collaborate on enriching specific pages as necessary.<br>
<br>
For 3/4, the requests tend to be to allow fields to be re-ordered, <br>
turned on/off.<br>
<br>
At the moment, the work doesn’t help any of these requests from users.<br>
<br>
<br>
[Victor] Agreed on these features, but think of Rafik’s change as a <br>
foundation work for these features. I don’t see how there is a <br>
conflict between these features and styling of pages.<br>
<br>
Whilst I did try to have a look at the Pull Request, there seems to be <br>
a number of Whitespace changes, and non-theme/design changes that make <br>
it impossible to review the patches.<br>
<br>
<br>
[Victor] I agree that the change has some white spacing issues that <br>
cause more changes than actually needed. Maybe Rafik can explore of <br>
this issue can be fixed with reasonable effort.<br>
<br>
Back in January, we agreed as a Team to get 1.3 shipped, and then look <br>
at UI and email notifications changes. Victor knows I’ve got some work <br>
on templating emails and pages within Mantis from back then, which I <br>
said I’d get a PR up for once the Database changes had been done - <br>
which we agreed as a team to do immediately after 1.3. So until we’ve <br>
done this, compared the two approaches and decide which route we want <br>
to go, i’m strongly against this getting merged.<br>
<br>
<br>
[Victor] Here is a case where you also have gone and implemented some <br>
change without discussion with the team. At that point I had <br>
discussed email templating (not UI tempting) and proposed an approach, <br>
some previews, and you complained and stopped the work. I’ve asked <br>
you then to share your code / approach and you haven’t. You just <br>
killed the momentum and said that you will publish your code by end of <br>
January then after 1.3. At that point we also agreed that code that <br>
is not published doesn’t exist and can’t be used to block other work. <br>
Rafik has shared a preview of this work with the team 1-2 month ago <br>
and everyone except you on the core team was excited and gave him UI <br>
level feedback which he addressed. So, I expect this code to be <br>
merged. The discussion is when exactly it is going to be merged based on the 1.3 plan.<br>
<br>
<br>
We agreed to ship 1.3 first so…<br>
<br>
When rafiq shared a preview with people 1-2 months ago was when i <br>
jumped in immediately and said:<br>
a) we should be discussing this on the dev list.<br>
b) we need to have a discussion on whether to go with bootstrap.<br>
c) I believe I said in the same post, we need to have a discussion on <br>
sidebar on the dev list.<br>
<br>
It’s really disappointing actually for me that Rafik has refused for 2 <br>
months to email the development list as it’s not enabled a discussion <br>
to take place properly. I think I said in the same email that I quite <br>
liked the design.<br>
<br>
Rafik is someone that’s never contributed to Mantis before, has never <br>
been introduced to us apart from dumping a website re-design and now <br>
has added a<br>
10,000 line commit, which is basically impossible to review.<br>
<br>
My purpose for asking him to communicate with the development list 2 <br>
months ago was so that we could have a discussion at an EARLY stage.<br>
<br>
As it is, until we get a PR that doesn’t contain X000 lines of <br>
incorrect whitespace changes in the first commit, it’s actually <br>
impossible to even attempt to review and look at what has been done. <br>
And that’s aside from the fact that we need to have a discussion around whether to use bootstrap.<br>
<br>
Paul<br>
<br>
<br>
On Mon, Aug 18, 2014 at 1:11 AM, Victor Boctor <<a href="mailto:***@gmail.com">***@gmail.com</a>> wrote:<br>
<br>
<blockquote type="cite">Paul,<br>
<br>
On Aug 17, 2014, at 2:23 AM, P Richards <<a href="mailto:***@mantisforge.org">***@mantisforge.org</a>> wrote:<br>
<br>
Alain,<br>
<br>
It’s even more painful, when it’s a big change, and changes the <br>
approach we go in Mantis - hasn’t been discussed on the mailing <br>
list, and there’s work in progress (well, on hold until after 1.3) <br>
to allow greater flexibility of theming mantis already. We agreed <br>
back in January to use the following approach regarding external libraries:<br>
<br>
<br>
[Victor] When Rafik contributed the new website in January, he was <br>
asked by several on the team to help out with doing the same for MantisBT itself.<br>
Hence, his contribution. He has used Bootstrap on the website and <br>
carried that forward to MantisBT itself. Given that he has followed <br>
through with this and put this hard word, I would expect that we <br>
would motivate him for that and appreciate the good work, rather than just being negative.<br>
<br>
Now, in terms of Rafiq’s work, I don’t necessarily see it as being a <br>
major problem (i.e. that we’ve got other work on theming) as I think <br>
it covers two different things - i.e. Rafiq’s trying to do a visual <br>
design, anything I’ve looked at tends to be working on allowing <br>
flexibility/functionality rather then visual effects, so the two probably go together in the end.<br>
<br>
<br>
[Victor] Exactly, the visual design is orthogonal to allows users to <br>
extend MantisBT through plugins. The believe Rafik’s suggested <br>
change was focused on revamping the visual design for all features. <br>
But to scope the change, it doesn’t try to go further than that. <br>
Once it is in, we can add more flexibility and modernize further.<br>
<br>
My main issue is we have plugin’s that add functionality, there’s <br>
multiple CSS frameworks out there now - Jquery UI, foundation, <br>
bootstrap etc, that we do need to consider our approach within <br>
Mantis. I’m pretty confident we could make a similar style using <br>
query ui, foundation or bootstrap - without two much work, so we need to decide what works best long term.<br>
<br>
<br>
[Victor] Bootstrap is a very popular and respected library. I think <br>
given that we have this used in the website and the proposed pull <br>
request now, I don’t see why we would go for something else. <br>
Bootstrap also provides a good story for responive design allowing <br>
us to have great native support for phones over time.<br>
<br>
The reason I started looking at using Jquery UI in the past (we <br>
actually moved the Jquery UI javascript from a plugin to the Mantis <br>
Core) was due to it being used by some plugins, and having the <br>
visual theme roller - which struck me as something that would allow <br>
an end user without HTML or CSS experience to brand Mantis into <br>
their company colours without very much work. Given that Mantis has <br>
found a whole bunch of uses - for both software development and <br>
non-software development workflows, this struck me originally as an easy win for end users and plugin author’s for styling.<br>
<br>
<br>
[Victor]