Discussion:
[mantisbt-dev] Should MantisBT 1.3 'provide' jQuery? (Resend)
Robert Munteanu
2015-07-30 07:58:33 UTC
Permalink
Hi,

In MantisBT 1.2 jQuery was provided by a plugin. In MantisBT 1.3 it's
included in the core. However, there are still plugins which require
jQuery.

To make it easier to support both MantisBT 1.2 and 1.3 in plugins we
could 'provide' a dummy jQuery plugin with the MantisBT core.

Thoughts?

Robert

------------------------------------------------------------------------------
Roland Becker
2015-08-02 08:32:14 UTC
Permalink
Consider also
https://www.mantisbt.org/bugs/view.php?id=17360 and
https://github.com/mantisbt/mantisbt/pull/239
when thinking about it

I prefer breaking things instead of some magic in the background that might
finally end in strange issues.
Of course, I am biased as I am quite often dealing with strange issues in our
forum ;-)

Roland
Post by Robert Munteanu
Hi,
In MantisBT 1.2 jQuery was provided by a plugin. In MantisBT 1.3 it's
included in the core. However, there are still plugins which require
jQuery.
To make it easier to support both MantisBT 1.2 and 1.3 in plugins we
could 'provide' a dummy jQuery plugin with the MantisBT core.
Thoughts?
Robert
------------------------------------------------------------------------------
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
------------------------------------------------------------------------------
Damien Regad
2015-08-02 19:36:47 UTC
Permalink
Post by Roland Becker
Post by Robert Munteanu
To make it easier to support both MantisBT 1.2 and 1.3 in plugins we
could 'provide' a dummy jQuery plugin with the MantisBT core.
Thoughts?
I prefer breaking things instead of some magic in the background that might
finally end in strange issues.
I'm with Roland here.

I believe the system I've put in place quite effectively deals with the
problem by disabling the plugin; this should force the plugin authors to
have a look at their code, and implement any necessary changes to ensure
proper operations with 1.3 and release a specific version.

I'm aware that this approach does put an additional burden on the plugin
authors (to maintain a dedicated 1.3 branch), but in my opinion it is a
better and safer alternative than the "dummy plugin" you suggest which
would anyway only cover part of the 1.3 compatibility problem.

In addition to jQuery support, authors also need to consider the revised
CSS, deprecated functions, new syntax for DB queries, etc.



------------------------------------------------------------------------------
Robert Munteanu
2015-08-07 13:15:21 UTC
Permalink
Post by Damien Regad
Post by Roland Becker
Post by Robert Munteanu
To make it easier to support both MantisBT 1.2 and 1.3 in plugins we
could 'provide' a dummy jQuery plugin with the MantisBT core.
Thoughts?
I prefer breaking things instead of some magic in the background that might
finally end in strange issues.
I'm with Roland here.
I believe the system I've put in place quite effectively deals with the
problem by disabling the plugin; this should force the plugin authors to
have a look at their code, and implement any necessary changes to ensure
proper operations with 1.3 and release a specific version.
I'm aware that this approach does put an additional burden on the plugin
authors (to maintain a dedicated 1.3 branch), but in my opinion it is a
better and safer alternative than the "dummy plugin" you suggest which
would anyway only cover part of the 1.3 compatibility problem.
In addition to jQuery support, authors also need to consider the revised
CSS, deprecated functions, new syntax for DB queries, etc.
So the answer is no, we should not 'provide' jQuery :-)

Thanks,

Robert
--
http://robert.muntea.nu/

------------------------------------------------------------------------------
Loading...