[mantisbt-dev] Fwd: [mantisbt-commits] [mantisbt/mantisbt] 53d064: bug_report.php: fix warning when not using attachm...

[Paul Richards]

a) I Didn't see a pull request for this?

b) there's a var_dump in this commit. I've created Mantis Bug #17324 (
http://www.mantisbt.org/bugs/view.php?id=17324) to track the pull request
for this issue. I'll submit a pull request to fix this when I get home from
work if no one else beats me to it.

c) I believe the bug here is actually in the implementation of the
helper_array_transpose function. I'm more inclined to fix this by modifying
the function to return an empty array() [so the output is always an array],
then to add the is_null check in the code. I've created 0017325:
helper_array_transpose should always return an array (to reflect that
proposal http://www.mantisbt.org/bugs/view.php?id=17325)

d) Whichever route we decide to take the bug fix in bug_report.php - do we
need to do the same with the code in bug_file_add.php that has the same
code block ?


---------- Forwarded message ----------
From: GitHub <***@github.com>
Date: Mon, May 12, 2014 at 9:42 AM
Subject: [mantisbt-commits] [mantisbt/mantisbt] 53d064: bug_report.php: fix
warning when not using attachm...
To: mantisbt-***@lists.sourceforge.net


Branch: refs/heads/master
Home: https://github.com/mantisbt/mantisbt
Commit: 53d0641690857b3b463cfa9ab77759e58a93125f

https://github.com/mantisbt/mantisbt/commit/53d0641690857b3b463cfa9ab77759e58a93125f
Author: Damien Regad <***@mantisbt.org>
Date: 2014-05-12 (Mon, 12 May 2014)

Changed paths:
M bug_report.php

Log Message:
-----------
bug_report.php: fix warning when not using attachments

When attachments are not used, 'ufile' is not defined, so $t_files
becomes NULL (line 150) causing the 'Invalid argument supplied for
foreach' warning.

Fixes #17322

[Damien Regad]

Post by Paul Richards
a) I Didn't see a pull request for this?

There was none.

Post by Paul Richards
b) there's a var_dump in this commit.I've created Mantis Bug #17324

Ooops. Thanks for reviewing and catching that. Fixed it.

Post by Paul Richards
c) I believe the bug here is actually in the implementation of the
helper_array_transpose function. I'm more inclined to fix this by
modifying the function to return an empty array() [so the output is
always an array], then to add the is_null check in the code. I've
created 0017325: helper_array_transpose should always return an array
(to reflect that proposal http://www.mantisbt.org/bugs/view.php?id=17325)

I actually thought about that, but decided to leave the API alone.
See my note in the issue, let's discuss there.

Post by Paul Richards
d) Whichever route we decide to take the bug fix in bug_report.php - do
we need to do the same with the code in bug_file_add.php that has the
same code block ?

Didn't consider that one, but yes, you're right. Fixed also.