P Richards
2014-08-11 18:13:21 UTC
As much as I agree with atrol's note (https://github.com/mantisbt/mantisbt/pull/215#discussion_r16026977), and think we do need to consider whether the part he refers to is actually a good idea.
I've fixed the code (hopefully) not to break travis builds due to CLI not having _SERVER set.
I'd argue that having fancy logic to detect error handling is a bad idea as some people may want to run mantis in production via atrols WAMP setup for instance, and would likely be running it locally for personal use, and not be a 'mantis developer', and therefore not want automatic developer settings turned on.
Personally, I think our error handling settings are too complex - when working on 2.0/next before, we simplified them to a "show_friendly_errors" command. At the moment, we have 2-3 settings, some of which consist of arrays of what to do when various types of errors occur etc etc. For the most part, I believe this is over complicated, and we should have two modes: a) live/production b) debug/developer.
I feel that the change Damien (/victor?) have come up with is more related to the fact that you need to read the manual to remember what $g_display_errors should be set up as when developing mantis then being a good idea ;)
Paul
-----Original Message-----
From: GitHub [mailto:***@github.com]
Sent: 11 August 2014 19:01
To: mantisbt-***@lists.sourceforge.net
Subject: [mantisbt-commits] [mantisbt/mantisbt] d9d784: Check that $_SERVER['SERVER_NAME'] is exists befor...
Branch: refs/heads/master
Home: https://github.com/mantisbt/mantisbt
Commit: d9d784f14ab9d434f454d3ea3f380cfa23bf4ddb
https://github.com/mantisbt/mantisbt/commit/d9d784f14ab9d434f454d3ea3f380cfa23bf4ddb
Author: Paul Richards <***@mantisforge.org>
Date: 2014-08-11 (Mon, 11 Aug 2014)
Changed paths:
M config_defaults_inc.php
Log Message:
-----------
Check that $_SERVER['SERVER_NAME'] is exists before use
I've fixed the code (hopefully) not to break travis builds due to CLI not having _SERVER set.
I'd argue that having fancy logic to detect error handling is a bad idea as some people may want to run mantis in production via atrols WAMP setup for instance, and would likely be running it locally for personal use, and not be a 'mantis developer', and therefore not want automatic developer settings turned on.
Personally, I think our error handling settings are too complex - when working on 2.0/next before, we simplified them to a "show_friendly_errors" command. At the moment, we have 2-3 settings, some of which consist of arrays of what to do when various types of errors occur etc etc. For the most part, I believe this is over complicated, and we should have two modes: a) live/production b) debug/developer.
I feel that the change Damien (/victor?) have come up with is more related to the fact that you need to read the manual to remember what $g_display_errors should be set up as when developing mantis then being a good idea ;)
Paul
-----Original Message-----
From: GitHub [mailto:***@github.com]
Sent: 11 August 2014 19:01
To: mantisbt-***@lists.sourceforge.net
Subject: [mantisbt-commits] [mantisbt/mantisbt] d9d784: Check that $_SERVER['SERVER_NAME'] is exists befor...
Branch: refs/heads/master
Home: https://github.com/mantisbt/mantisbt
Commit: d9d784f14ab9d434f454d3ea3f380cfa23bf4ddb
https://github.com/mantisbt/mantisbt/commit/d9d784f14ab9d434f454d3ea3f380cfa23bf4ddb
Author: Paul Richards <***@mantisforge.org>
Date: 2014-08-11 (Mon, 11 Aug 2014)
Changed paths:
M config_defaults_inc.php
Log Message:
-----------
Check that $_SERVER['SERVER_NAME'] is exists before use