I don’t think you are hearing what the team is saying… I know what are you saying, but I don’t think the team is on board with it. I wanted to branch, the team wasn’t on board. I decide to compromise and re-discuss after 1.3.0a1 is out.
We need to have a criteria to accept / reject these pull requests, and my feel based on the thread so far, is that if you just keep porting stuff, there will be good portion that won’t make sense to pass the pull request phase.
Reviewing these pull requests also takes time, so lets make sure that we are making good use of everyone’s time.
If we decide to accept all your pull requests, then we might as well open it for all to get in whatever they have time to get in.
I disagree with the statement about 1.3 not about to quality bar yet, and your checkins are making it better. A lot of the changes are good changes but are not fixing issues that affect our ability to ship 1.3. Or even fixing a bug that an end user would benefit from.
Now if I’m wrong about that, then feel free to present your case in each of the pull requests.
Post by Paul RichardsHi Victor,
Indeed - there's a number of changes from 2.0/next branches that I'm not
pulling across at this stage. For example 'bug objects' and "MantisContext"
work ( the 2nd at least, I think roland quite liked)
As I said to roland's reply, I'd like to see us ensure a good quality 1.3
release. At the moment, I don't think we are ready to achieve that.
I've already said the timescale I think we should work too in terms of new
code and fixing stuff - end of October.
In any case, I'm going to be doing several pull requests a day until end of
October and at that point will be stopping and focusing on bug-fixing and
testing for a good quality 1.3 release.
Hopefully by that point we'll have a new build system in place, and enhanced
phpunit tests which should aid the testing process.
Paul
-----Original Message-----
Sent: 21 September 2014 23:33
To: Paul Richards
Cc: MantisBT Dev Mailing List
Subject: Re: [mantisbt-dev] Staging 1.3 for release
Paul, the goal is not to pull all the changes in 2.0/next. We avoided these
branches to reduce the churn to enable 1.3 going out and to be able to
review the changes. You porting these changes fixed the latter, but not the
churn problem.
- (Paul) stop submitting 5-10 pull requests per day for now,
- focus on testing and fixing issues and stabilization instead, then
- get alpha out the door ASAP, and
- resume the new features fest after 1.3.0a1 is out.
- blocking bug fixes
- functional bug fixes
- security bugs
Branching to be discussed after 1.3a1 is out.
Let's focus on stablization, upgrading our tracker and getting 1.3.0a1/b1
out.
I've started doing some testing on master and adding some 1.3 support to
plugins that I authored or contributed to.
I'll also start responding to pull requests based on the above criteria
since at least 3 of us seem to be on board with it.
Post by Damien RegadRoland,
I think the initial with the 1.2 and historical fixes was that we didn't
have plan post 1.2.
Post by Damien RegadIn terms of 1.3, I'd like to see us support this longer term, so I think
it would be good to see us bug port more bug fixes.
Post by Damien RegadI've not had much time so far in September to spend on Mantis Development,
as I work in a school and the first few weeks are really busy.
Post by Damien RegadNow that the first few weeks are done, I should be able to dedicate more
time towards mantis. At the moment, I'm going through existing patches that
people offered to help get committed from next/master-2.x before we look at
1.3.
Post by Damien RegadYou'll probably see the pace of that development accelerate over the next
month as I'll have some free time to work on Mantis, coupled with some free
work time to throw in.
Post by Damien RegadHopefully we can get as much merged as possible to reduce both the work in
keeping the patches sync'd up to the current master, and to avoid having
what we've had before of doing a release and then having massive churn on
master.
Post by Damien RegadI will have pull requests for every patch against master-2 / next in
github within the next 7-10 days.
Post by Damien RegadThis will allow us to delete the historical next/master-2.x branches.
I've then got 2-3 new features that I'd like to put forward in October,
and plan to spend some time trying to stabilise master for a release at that
point.
Post by Damien RegadI suggested two weeks ago that we set a date of end of October for new
development - when I said " to branch 1.3 for release" - I meant for an
alpha release, and not for a final release.
Post by Damien RegadIn terms of 'when to branch' - we should branch master into 1.3 before the
first alpha release. But equally, that should be done at the point
everyone's had a chance to get any changes in before the branch. Whilst I
know that I've not had much time to dedicate to Mantis for the last month,
and I know I'm about to get a chunk of time to spend on mantis for the next
month, others may have different schedules. The rational for saying we
should set an "end of October" or even "end of November" date or similar
timescale was to give everyone a chance to finalise any patches before we
move to a period of stabilisation.
Post by Damien RegadPaul
-----Original Message-----
Sent: 19 September 2014 10:51
To: developer discussions; Victor Boctor
Subject: Re: [mantisbt-dev] Staging 1.3 for release
Victor,
I mentioned some time before that I would like to see the branch _after_
1.3.0 or even better 1.3.1 This is to avoid the additional work that is
needed to implement fixes for two branches.
Post by Damien RegadIt seems that you don't consider this approach.
Ok, at least we shouldn't branch before the fixes for let's say the second
official beta version are implemented and at least the following issues [1]
are fixed.
Post by Damien RegadI fear that we will see quite soon some commits from Victor and Paul in
master after the branch has been created that will complicate porting
changes from 1.3 to 2.0.
Post by Damien RegadI fear also, that Victor and Paul will not invest that much time in fixing
bugs in 1.3 and port them to 2.0.
Post by Damien RegadSome developers had certainly some pleasure to add new stuff to master / next /
2.0 whereas other developers had not that much pleasure to fix hundreds of
bugs in 1.2.x and to port the fixes to master.
Post by Damien RegadTo get a rough impression of what I mean, check "Assigned To" from [2]
dregad 264
rombert 102
atrol 45
vboctor 31 (even less if you don't count the issues driven by
MantisTouch) grangeway 5
I hope we will not see the same story for 1.3.
Did someone test that all plugins running on mantisbt.org/bugs are running
fine with current master?
Post by Damien RegadMaybe some of them can/should be deactivated.
At least "Source control integration" and "Snippets" should work.
Roland
[1]
http://www.mantisbt.org/bugs/search.php?project_id=1&sticky_issues=off
&sortby=last_updated&dir=DESC&hide_status_id=-2&match_type=0
[2]
http://www.mantisbt.org/bugs/search.php?project_id=1&sticky_issues=off
&fixed_in_version[]=1.2.x&fixed_in_version[]=1.2.17&fixed_in_version[]
=1.2.16&fixed_in_version[]=1.2.15&fixed_in_version[]=1.2.14&fixed_in_v
ersion[]=1.2.13&fixed_in_version[]=1.2.12&fixed_in_version[]=1.2.11&fi
xed_in_version[]=1.2.10&fixed_in_version[]=1.2.9&fixed_in_version[]=1.
2.8&fixed_in_version[]=1.2.7&fixed_in_version[]=1.2.6&fixed_in_version
[]=1.2.5&fixed_in_version[]=1.2.4&fixed_in_version[]=1.2.3&fixed_in_ve
rsion[]=1.2.2&fixed_in_version[]=1.2.1&sortby=handler_id&dir=DESC&hide
_status_id=-2&match_type=0
Post by Victor BoctorHi all,
It has become a habit to discuss this topic every couple of month.
I'm seeing there is a lot of activity in terms of checkins, but I
want us to make sure we are on a path to getting 1.3 out of the door.
We have always been a month or two away with desire to get some more
stuff in.
Post by Damien RegadPost by Victor BoctorAt the moment, there is a lot of churn on master that can be
classified as good change, but not really needed for 1.3 to go out.
- Branch for 1.3
- Upgrade our bug tracker to 1.3 branch.
- Put this branch in bug fix only mode.
- A better chance at stabilizing (based on blocking bugs) and releasing.
- Ability to release 1.3 beta/alpha and get more testing.
- Continue doing back porting of good changes, but are not critical to
1.3 release without destabilizing.
- Unblock 2.0 changes
Hope that makes sense.
Thanks,
-Victor
---------------------------------------------------------------------
-
-------- Slashdot TV. Video for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.
clktrk_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
----------------------------------------------------------------------
-------- Slashdot TV. Video for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.
clktrk _______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
----------------------------------------------------------------------------
--
Slashdot TV. Video for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
------------------------------------------------------------------------------
Slashdot TV. Video for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev