Discussion:
[mantisbt-dev] Adding agileMantis as a new plugin
Koch, Jan
2014-06-04 09:21:56 UTC
Permalink
Hi MantisBT-Dev Team,

we would like to commit our new plugin to the MantisBT plugin list.

Our plugin is called agileMantis and enables the scrum framework to an existing MantisBT installation.

The repository can be found on github and sourceforge:

- Github: https://github.com/jako87/agileMantis

- Sourceforge: http://sourceforge.net/projects/agilemantis/

The following people should have access to the repository:

- jazsch

- jssw

- jako87

If you want to see a demo version of this plugin, you can go to http://agilemantis.sourceforge.net

I would be glad hearing from you.

Best Regards

Jan Koch
Junior Software Engineer
________________________________
gadiv GmbH
Bövingen 148
53804 Much
Tel.:

+49 (0)2245 / 9160-32

Fax:

+49 (0)2245 / 9160-21

E-Mail:

***@gadiv.de<mailto:***@gadiv.de>

Web:

www.gadiv.de<http://www.gadiv.de/>


Vertreten durch die Geschäftsführer:
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen

Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
________________________________
Alain D'EURVEILHER
2014-06-04 10:45:27 UTC
Permalink
Hi Jan Koch,
I'm a user of your plugin (and not part of the Mantis dev team), but I've
been testing your plugin v1.3 with Mantis 1.2.17.

It appears that you still have syntaxt issues in your source code, such as
opening php tags <? without the php (instead of <?php)
for instance <?if (...)
or <?echo (...)
which makes it fail when installing.

Also, some of your custom string are undified in the manage settings page.
For instance:
APPLICATION WARNING #300: String "RankingOrder" not found.



I'm just saying, but maybe it could be wise to fix these before puting it
in the mantisBT list no ?

best regards,
AlainD.
Post by Koch, Jan
Hi MantisBT-Dev Team,
we would like to commit our new plugin to the MantisBT plugin list.
Our plugin is called agileMantis and enables the scrum framework to an
existing MantisBT installation.
- Github: https://github.com/jako87/agileMantis
- Sourceforge: http://sourceforge.net/projects/agilemantis/
- jazsch
- jssw
- jako87
If you want to see a demo version of this plugin, you can go to
http://agilemantis.sourceforge.net
I would be glad hearing from you.
Best Regards
Jan Koch
Junior Software Engineer
------------------------------
gadiv GmbH
Bövingen 148
53804 Much
+49 (0)2245 / 9160-32
+49 (0)2245 / 9160-21
www.gadiv.de
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen
Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
------------------------------
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.
Koch, Jan
2014-06-04 10:58:21 UTC
Permalink
Hallo AlainD,

thanks for your response to our request.

Could you tell me where you found these errors?

Regarding the missing Ranking Order string:

Do you have a file called custom_strings_inc.php in your MantisBT main directory?

If not create that file and put the following lines in it:

<?php
switch( lang_get_current() ){
case 'german':
$s_Presentable = "PrÀsentabel";
$s_InReleaseDocu = "In Freigabedoku";
$s_PlannedWork = "Planaufwand";
$s_RankingOrder = "Rangfolge";
$s_Technical = "Technisch";
$s_PlannedWorkUnit = "Aufwandseinheit";
break;
case 'english':
$s_Presentable = "Presentable";
$s_InReleaseDocu = "In Releasedocu";
$s_PlannedWork = "Planned Work";
$s_RankingOrder = "Ranking Order";
$s_Technical = "Technical";
$s_PlannedWorkUnit = "Planned Work Unit";
break;
}
$s_ProductBacklog = "Product Backlog";
$s_BusinessValue = "Business Value";
?>

Best Regards

Jan Koch
Junior Software Engineer
________________________________
gadiv GmbH
Bövingen 148
53804 Much
Tel.:

+49 (0)2245 / 9160-32

Fax:

+49 (0)2245 / 9160-21

E-Mail:

***@gadiv.de<mailto:***@gadiv.de>

Web:

www.gadiv.de<http://www.gadiv.de/>


Vertreten durch die GeschÀftsfÌhrer:
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen

Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
________________________________

Von: Alain D'EURVEILHER [mailto:***@gmail.com]
Gesendet: Mittwoch, 4. Juni 2014 12:45
An: developer discussions
Betreff: Re: [mantisbt-dev] Adding agileMantis as a new plugin

Hi Jan Koch,
I'm a user of your plugin (and not part of the Mantis dev team), but I've been testing your plugin v1.3 with Mantis 1.2.17.
It appears that you still have syntaxt issues in your source code, such as opening php tags <? without the php (instead of <?php)
for instance <?if (...)
or <?echo (...)
which makes it fail when installing.
Also, some of your custom string are undified in the manage settings page. For instance:
APPLICATION WARNING #300: String "RankingOrder" not found.


I'm just saying, but maybe it could be wise to fix these before puting it in the mantisBT list no ?
best regards,
AlainD.

On Wed, Jun 4, 2014 at 11:21 AM, Koch, Jan <***@gadiv.de<mailto:***@gadiv.de>> wrote:
Hi MantisBT-Dev Team,

we would like to commit our new plugin to the MantisBT plugin list.

Our plugin is called agileMantis and enables the scrum framework to an existing MantisBT installation.

The repository can be found on github and sourceforge:

- Github: https://github.com/jako87/agileMantis

- Sourceforge: http://sourceforge.net/projects/agilemantis/

The following people should have access to the repository:

- jazsch

- jssw

- jako87

If you want to see a demo version of this plugin, you can go to http://agilemantis.sourceforge.net

I would be glad hearing from you.

Best Regards

Jan Koch
Junior Software Engineer
________________________________
gadiv GmbH
Bövingen 148
53804 Much
Tel.:

+49 (0)2245 / 9160-32<tel:%2B49%20%280%292245%20%2F%209160-32>

Fax:

+49 (0)2245 / 9160-21<tel:%2B49%20%280%292245%20%2F%209160-21>

E-Mail:

***@gadiv.de<mailto:***@gadiv.de>

Web:

www.gadiv.de<http://www.gadiv.de/>


Vertreten durch die GeschÀftsfÌhrer:
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen

Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
________________________________


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
mantisbt-***@lists.sourceforge.net<mailto:mantisbt-***@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.
Alain D'EURVEILHER
2014-06-05 06:38:11 UTC
Permalink
That's not the purpose of the custom_strings_inc.php. The translations of
the plugins labels must be handled directly in the plugin's 'lang'
directory which you already did by the way. It's just that you still use
lang_get() instead of plugin_lang_get() in your config.php page.
For instance instead of "lang_get( 'RankingOrder' )" you should used
"plugin_lang_get( 'RankingOrder' )" instead, etc...
The same thing for the other options: 'Presentable', 'Technical',
'InReleaseDocu' and 'PlannedWork'. The strings are already defined in your
strings_english.txt file.

Second,
Here is so far what I needed to manually modify in the v1.3 in order to
make it work, by replacing all the <? by <?php:

1) agileMantis.php: l.154: <?foreach => <?php foreach($pbl AS $num =>
$row){ ?> (with a space also between the "{" and the closing tag "?>" )
2) agileMantis.php: l.156: <?}?> => <?php }?>
3) agileMantis.php: l.157: <? => <?php

4) agileMantisCustomFields.php: l.114: $row){?> => $row){ ?>
5) agileMantisCustomFields.php: l.115: added a space or a ; before all the
?>: $row['name']?> => $row['name'];?>
6) agileMantisCustomFields.php: l.116: <?}?> => <?php }?>
7) agileMantisCustomFields.php: l.117: <? => <?php

8) capacity.php: l.285: <? => <?php

9) config.php: l.127: <?if(plugin_config_get => <?php if(plugin_config_get
10) config.php: l.213, l.218, l.223, l.228, l.233: echo lang_get( => echo
plugin_lang_get(

11) sprint_backlog_actions.php: replace all "<?if(" by "<?php if("


Best regards.
AlainD.
Post by Koch, Jan
Hallo AlainD,
thanks for your response to our request.
Could you tell me where you found these errors?
Do you have a file called custom_strings_inc.php in your MantisBT main directory?
<?php
switch( lang_get_current() ){
$s_Presentable = "PrÀsentabel";
$s_InReleaseDocu = "In Freigabedoku";
$s_PlannedWork = "Planaufwand";
$s_RankingOrder = "Rangfolge";
$s_Technical = "Technisch";
$s_PlannedWorkUnit = "Aufwandseinheit";
break;
$s_Presentable = "Presentable";
$s_InReleaseDocu = "In Releasedocu";
$s_PlannedWork = "Planned Work";
$s_RankingOrder = "Ranking Order";
$s_Technical = "Technical";
$s_PlannedWorkUnit = "Planned Work Unit";
break;
}
$s_ProductBacklog = "Product Backlog";
$s_BusinessValue = "Business Value";
?>
Best Regards
Jan Koch
Junior Software Engineer
------------------------------
gadiv GmbH
Bövingen 148
53804 Much
+49 (0)2245 / 9160-32
+49 (0)2245 / 9160-21
www.gadiv.de
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen
Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
------------------------------
*Gesendet:* Mittwoch, 4. Juni 2014 12:45
*An:* developer discussions
*Betreff:* Re: [mantisbt-dev] Adding agileMantis as a new plugin
Hi Jan Koch,
I'm a user of your plugin (and not part of the Mantis dev team), but I've
been testing your plugin v1.3 with Mantis 1.2.17.
It appears that you still have syntaxt issues in your source code, such as
opening php tags <? without the php (instead of <?php)
for instance <?if (...)
or <?echo (...)
which makes it fail when installing.
APPLICATION WARNING #300: String "RankingOrder" not found.
I'm just saying, but maybe it could be wise to fix these before puting
it in the mantisBT list no ?
best regards,
AlainD.
Hi MantisBT-Dev Team,
we would like to commit our new plugin to the MantisBT plugin list.
Our plugin is called agileMantis and enables the scrum framework to an
existing MantisBT installation.
- Github: https://github.com/jako87/agileMantis
- Sourceforge: http://sourceforge.net/projects/agilemantis/
- jazsch
- jssw
- jako87
If you want to see a demo version of this plugin, you can go to
http://agilemantis.sourceforge.net
I would be glad hearing from you.
Best Regards
Jan Koch
Junior Software Engineer
------------------------------
gadiv GmbH
Bövingen 148
53804 Much
+49 (0)2245 / 9160-32
+49 (0)2245 / 9160-21
www.gadiv.de
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen
Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
------------------------------
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.
Koch, Jan
2014-06-05 06:58:14 UTC
Permalink
Hallo Alain,

thanks for your response to my question.

the custom_strings_inc.php is used for the translation of the custom fields.

Nearly a year ago I wrote with one guy of the support chat and he gave me the advice to create this file and save all mantisbt custom field translations in it.
Additionally we put the custom field translation in every language file from the plugin. It may be better only to have one source for this.

Thank you again for having a look at the source again and looking for the positions of the shorttags. I thought that I replaced all short tags

We will replace all findings.

Best Regards

Jan Koch
Junior Software Engineer
________________________________
gadiv GmbH
Bövingen 148
53804 Much
Tel.:

+49 (0)2245 / 9160-32

Fax:

+49 (0)2245 / 9160-21

E-Mail:

***@gadiv.de<mailto:***@gadiv.de>

Web:

www.gadiv.de<http://www.gadiv.de/>


Vertreten durch die GeschÀftsfÌhrer:
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen

Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
________________________________

Von: Alain D'EURVEILHER [mailto:***@gmail.com]
Gesendet: Donnerstag, 5. Juni 2014 08:38
An: developer discussions
Betreff: Re: [mantisbt-dev] Adding agileMantis as a new plugin

That's not the purpose of the custom_strings_inc.php. The translations of the plugins labels must be handled directly in the plugin's 'lang' directory which you already did by the way. It's just that you still use lang_get() instead of plugin_lang_get() in your config.php page.
For instance instead of "lang_get( 'RankingOrder' )" you should used "plugin_lang_get( 'RankingOrder' )" instead, etc...
The same thing for the other options: 'Presentable', 'Technical', 'InReleaseDocu' and 'PlannedWork'. The strings are already defined in your strings_english.txt file.
Second,
Here is so far what I needed to manually modify in the v1.3 in order to make it work, by replacing all the <? by <?php:

1) agileMantis.php: l.154: <?foreach => <?php foreach($pbl AS $num => $row){ ?> (with a space also between the "{" and the closing tag "?>" )
2) agileMantis.php: l.156: <?}?> => <?php }?>
3) agileMantis.php: l.157: <? => <?php

4) agileMantisCustomFields.php: l.114: $row){?> => $row){ ?>
5) agileMantisCustomFields.php: l.115: added a space or a ; before all the ?>: $row['name']?> => $row['name'];?>
6) agileMantisCustomFields.php: l.116: <?}?> => <?php }?>
7) agileMantisCustomFields.php: l.117: <? => <?php

8) capacity.php: l.285: <? => <?php

9) config.php: l.127: <?if(plugin_config_get => <?php if(plugin_config_get
10) config.php: l.213, l.218, l.223, l.228, l.233: echo lang_get( => echo plugin_lang_get(

11) sprint_backlog_actions.php: replace all "<?if(" by "<?php if("

Best regards.
AlainD.


On Wed, Jun 4, 2014 at 12:58 PM, Koch, Jan <***@gadiv.de<mailto:***@gadiv.de>> wrote:
Hallo AlainD,

thanks for your response to our request.

Could you tell me where you found these errors?

Regarding the missing Ranking Order string:

Do you have a file called custom_strings_inc.php in your MantisBT main directory?

If not create that file and put the following lines in it:

<?php
switch( lang_get_current() ){
case 'german':
$s_Presentable = "PrÀsentabel";
$s_InReleaseDocu = "In Freigabedoku";
$s_PlannedWork = "Planaufwand";
$s_RankingOrder = "Rangfolge";
$s_Technical = "Technisch";
$s_PlannedWorkUnit = "Aufwandseinheit";
break;
case 'english':
$s_Presentable = "Presentable";
$s_InReleaseDocu = "In Releasedocu";
$s_PlannedWork = "Planned Work";
$s_RankingOrder = "Ranking Order";
$s_Technical = "Technical";
$s_PlannedWorkUnit = "Planned Work Unit";
break;
}
$s_ProductBacklog = "Product Backlog";
$s_BusinessValue = "Business Value";
?>

Best Regards

Jan Koch
Junior Software Engineer
________________________________
gadiv GmbH
Bövingen 148
53804 Much
Tel.:

+49 (0)2245 / 9160-32<tel:%2B49%20%280%292245%20%2F%209160-32>

Fax:

+49 (0)2245 / 9160-21<tel:%2B49%20%280%292245%20%2F%209160-21>

E-Mail:

***@gadiv.de<mailto:***@gadiv.de>

Web:

www.gadiv.de<http://www.gadiv.de/>


Vertreten durch die GeschÀftsfÌhrer:
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen

Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
________________________________

Von: Alain D'EURVEILHER [mailto:***@gmail.com<mailto:***@gmail.com>]
Gesendet: Mittwoch, 4. Juni 2014 12:45
An: developer discussions
Betreff: Re: [mantisbt-dev] Adding agileMantis as a new plugin

Hi Jan Koch,
I'm a user of your plugin (and not part of the Mantis dev team), but I've been testing your plugin v1.3 with Mantis 1.2.17.
It appears that you still have syntaxt issues in your source code, such as opening php tags <? without the php (instead of <?php)
for instance <?if (...)
or <?echo (...)
which makes it fail when installing.
Also, some of your custom string are undified in the manage settings page. For instance:
APPLICATION WARNING #300: String "RankingOrder" not found.

I'm just saying, but maybe it could be wise to fix these before puting it in the mantisBT list no ?
best regards,
AlainD.

On Wed, Jun 4, 2014 at 11:21 AM, Koch, Jan <***@gadiv.de<mailto:***@gadiv.de>> wrote:
Hi MantisBT-Dev Team,

we would like to commit our new plugin to the MantisBT plugin list.

Our plugin is called agileMantis and enables the scrum framework to an existing MantisBT installation.

The repository can be found on github and sourceforge:

- Github: https://github.com/jako87/agileMantis

- Sourceforge: http://sourceforge.net/projects/agilemantis/

The following people should have access to the repository:

- jazsch

- jssw

- jako87

If you want to see a demo version of this plugin, you can go to http://agilemantis.sourceforge.net

I would be glad hearing from you.

Best Regards

Jan Koch
Junior Software Engineer
________________________________
gadiv GmbH
Bövingen 148
53804 Much
Tel.:

+49 (0)2245 / 9160-32<tel:%2B49%20%280%292245%20%2F%209160-32>

Fax:

+49 (0)2245 / 9160-21<tel:%2B49%20%280%292245%20%2F%209160-21>

E-Mail:

***@gadiv.de<mailto:***@gadiv.de>

Web:

www.gadiv.de<http://www.gadiv.de/>


Vertreten durch die GeschÀftsfÌhrer:
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen

Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
________________________________


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
mantisbt-***@lists.sourceforge.net<mailto:mantisbt-***@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
mantisbt-***@lists.sourceforge.net<mailto:mantisbt-***@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.
Alain D'EURVEILHER
2014-06-05 07:27:33 UTC
Permalink
You're welcome. I think that the short tags would just work fine if you
added a space after them. But now since they often stick the following
instruction, it does work.

By the way there another issue I just discovered: The first project backlog
cannot be created.
Indead in your install.php you create the tables as:

CREATE TABLE IF NOT EXISTS `gadiv_productbacklogs` (
`id` int(11) unsigned NOT NULL AUTO_INCREMENT,
`name` varchar(255) CHARACTER SET utf8 NOT NULL,
`description` text CHARACTER SET utf8 NOT NULL,
`user_id` int(11) unsigned NOT NULL,

Note the not nullable instructions for the columns description and user_id
WITHOUT default values.
But when creating a product_backlog newProductBacklog(){}, you try to
insert in that table (l.52)
INSERT INTO `gadiv_productbacklogs` SET `name` = 'test PBL 1', description
= '';
without user_id, which makes MySQL complain about, because user_id is not
defined!

This is one issue I just discovered, I wonder how many more I will get.

If I may, I would suggest you to make a clean install of your plugin in
another mantis for tests, in order to detect all what you've missed when
developping your plugin on your current installation.

Regards,
AlainD.
Post by Koch, Jan
Hallo Alain,
thanks for your response to my question.
the custom_strings_inc.php is used for the translation of the custom fields.
Nearly a year ago I wrote with one guy of the support chat and he gave me
the advice to create this file and save all mantisbt custom field
translations in it.
Additionally we put the custom field translation in every language file
from the plugin. It may be better only to have one source for this.
Thank you again for having a look at the source again and looking for the
positions of the shorttags. I thought that I replaced all short tags

We will replace all findings.
Best Regards
Jan Koch
Junior Software Engineer
------------------------------
gadiv GmbH
Bövingen 148
53804 Much
+49 (0)2245 / 9160-32
+49 (0)2245 / 9160-21
www.gadiv.de
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen
Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
------------------------------
*Gesendet:* Donnerstag, 5. Juni 2014 08:38
*An:* developer discussions
*Betreff:* Re: [mantisbt-dev] Adding agileMantis as a new plugin
That's not the purpose of the custom_strings_inc.php. The translations of
the plugins labels must be handled directly in the plugin's 'lang'
directory which you already did by the way. It's just that you still use
lang_get() instead of plugin_lang_get() in your config.php page.
For instance instead of "lang_get( 'RankingOrder' )" you should used
"plugin_lang_get( 'RankingOrder' )" instead, etc...
The same thing for the other options: 'Presentable', 'Technical',
'InReleaseDocu' and 'PlannedWork'. The strings are already defined in your
strings_english.txt file.
Second,
Here is so far what I needed to manually modify in the v1.3 in order to
1) agileMantis.php: l.154: <?foreach => <?php foreach($pbl AS $num =>
$row){ ?> (with a space also between the "{" and the closing tag "?>" )
2) agileMantis.php: l.156: <?}?> => <?php }?>
3) agileMantis.php: l.157: <? => <?php
4) agileMantisCustomFields.php: l.114: $row){?> => $row){ ?>
5) agileMantisCustomFields.php: l.115: added a space or a ; before all
the ?>: $row['name']?> => $row['name'];?>
6) agileMantisCustomFields.php: l.116: <?}?> => <?php }?>
7) agileMantisCustomFields.php: l.117: <? => <?php
8) capacity.php: l.285: <? => <?php
9) config.php: l.127: <?if(plugin_config_get => <?php if(plugin_config_get
10) config.php: l.213, l.218, l.223, l.228, l.233: echo lang_get( => echo plugin_lang_get(
11) sprint_backlog_actions.php: replace all "<?if(" by "<?php if("
Best regards.
AlainD.
Hallo AlainD,
thanks for your response to our request.
Could you tell me where you found these errors?
Do you have a file called custom_strings_inc.php in your MantisBT main directory?
<?php
switch( lang_get_current() ){
$s_Presentable = "PrÀsentabel";
$s_InReleaseDocu = "In Freigabedoku";
$s_PlannedWork = "Planaufwand";
$s_RankingOrder = "Rangfolge";
$s_Technical = "Technisch";
$s_PlannedWorkUnit = "Aufwandseinheit";
break;
$s_Presentable = "Presentable";
$s_InReleaseDocu = "In Releasedocu";
$s_PlannedWork = "Planned Work";
$s_RankingOrder = "Ranking Order";
$s_Technical = "Technical";
$s_PlannedWorkUnit = "Planned Work Unit";
break;
}
$s_ProductBacklog = "Product Backlog";
$s_BusinessValue = "Business Value";
?>
Best Regards
Jan Koch
Junior Software Engineer
------------------------------
gadiv GmbH
Bövingen 148
53804 Much
+49 (0)2245 / 9160-32
+49 (0)2245 / 9160-21
www.gadiv.de
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen
Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
------------------------------
*Gesendet:* Mittwoch, 4. Juni 2014 12:45
*An:* developer discussions
*Betreff:* Re: [mantisbt-dev] Adding agileMantis as a new plugin
Hi Jan Koch,
I'm a user of your plugin (and not part of the Mantis dev team), but I've
been testing your plugin v1.3 with Mantis 1.2.17.
It appears that you still have syntaxt issues in your source code, such as
opening php tags <? without the php (instead of <?php)
for instance <?if (...)
or <?echo (...)
which makes it fail when installing.
APPLICATION WARNING #300: String "RankingOrder" not found.
I'm just saying, but maybe it could be wise to fix these before puting
it in the mantisBT list no ?
best regards,
AlainD.
Hi MantisBT-Dev Team,
we would like to commit our new plugin to the MantisBT plugin list.
Our plugin is called agileMantis and enables the scrum framework to an
existing MantisBT installation.
- Github: https://github.com/jako87/agileMantis
- Sourceforge: http://sourceforge.net/projects/agilemantis/
- jazsch
- jssw
- jako87
If you want to see a demo version of this plugin, you can go to
http://agilemantis.sourceforge.net
I would be glad hearing from you.
Best Regards
Jan Koch
Junior Software Engineer
------------------------------
gadiv GmbH
Bövingen 148
53804 Much
+49 (0)2245 / 9160-32
+49 (0)2245 / 9160-21
www.gadiv.de
Walter Jenauer, Axel Heuchmer, Werner Mauelshagen
Gesellschaftssitz: Much
Amtsgericht Siegburg HRB 2487
USt-ID DE123109137
------------------------------
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.
Damien Regad
2014-06-05 09:19:17 UTC
Permalink
Hi Jan

As a foreword, please note that I did not actually test the plugin, not
enough time (sorry).

I had a quick look at the installer when I saw in Alain's last comment
that you were using a CREATE TABLE statement, and in fact I have some
serious issues with the way you setup your plugin (install.php).

I don't think it's right that a plugin should edit the user's config
files. In my opinion, plugins should be self-contained, what you're
doing looks like an ugly hack. As a Mantis user/admin, I would not want
anyone to mess with my config, especially not 3rd party code.

Also, you should not directly insert data into Mantis base tables (like
you do when creating custom fields). You should work instead with the
relevant Mantis APIs to achieve what you want. What you're doing will
almost certainly cause maintenance issues in the future (e.g if we
change the table structure).

Likewise, you should not directly create tables within the Mantis
schema. The proper approach is to work with schema() method to manage
plugin-specific tables. That gives you the added benefit of versioning
your plugin's schema, and easier upgrade paths if your schema evolves in
the future; you can also create non-sql based schema steps calling PHP
code with 'UpdateFunction'. As an example, have a look at Source
Integration plugin [1] and also MantisBT's schema/installer [2]

Finally and perhaps most importantly, you're relying on mysql_query()
calls. This is very bad as you're effectively bypassing Mantis' DB api,
and removing support for other DB engines. You should use
db_query_bound() to execute your SQL statements.

As it is, and without looking further into your code, I think there is a
lot of work to do before we can consider this a "proper" plugin (no
offense).

I strongly encourage you to have a look at other existing plugins as
reference, particularly those authored by John Reese who wrote Mantis'
plugin API and framework.

I hope you will find my comments useful, let me know if you need help.

Damien


[1]
https://github.com/mantisbt-plugins/source-integration/blob/master/Source/Source.php#L154
and also
[2]
https://github.com/mantisbt/mantisbt/blob/master/admin/schema.php#L591 and

https://github.com/mantisbt/mantisbt/blob/master/core/install_helper_functions_api.php


---
This email is free from viruses and malware because avast! Antivirus protection is active.
http://www.avast.com
Alain D'EURVEILHER
2014-06-05 11:44:09 UTC
Permalink
Yeah,
Maybe I can contribute as well, if you need to...
Post by Alain D'EURVEILHER
Hi Jan
As a foreword, please note that I did not actually test the plugin, not
enough time (sorry).
I had a quick look at the installer when I saw in Alain's last comment
that you were using a CREATE TABLE statement, and in fact I have some
serious issues with the way you setup your plugin (install.php).
I don't think it's right that a plugin should edit the user's config
files. In my opinion, plugins should be self-contained, what you're
doing looks like an ugly hack. As a Mantis user/admin, I would not want
anyone to mess with my config, especially not 3rd party code.
Also, you should not directly insert data into Mantis base tables (like
you do when creating custom fields). You should work instead with the
relevant Mantis APIs to achieve what you want. What you're doing will
almost certainly cause maintenance issues in the future (e.g if we
change the table structure).
Likewise, you should not directly create tables within the Mantis
schema. The proper approach is to work with schema() method to manage
plugin-specific tables. That gives you the added benefit of versioning
your plugin's schema, and easier upgrade paths if your schema evolves in
the future; you can also create non-sql based schema steps calling PHP
code with 'UpdateFunction'. As an example, have a look at Source
Integration plugin [1] and also MantisBT's schema/installer [2]
Finally and perhaps most importantly, you're relying on mysql_query()
calls. This is very bad as you're effectively bypassing Mantis' DB api,
and removing support for other DB engines. You should use
db_query_bound() to execute your SQL statements.
As it is, and without looking further into your code, I think there is a
lot of work to do before we can consider this a "proper" plugin (no
offense).
I strongly encourage you to have a look at other existing plugins as
reference, particularly those authored by John Reese who wrote Mantis'
plugin API and framework.
I hope you will find my comments useful, let me know if you need help.
Damien
[1]
https://github.com/mantisbt-plugins/source-integration/blob/master/Source/Source.php#L154
and also
[2]
https://github.com/mantisbt/mantisbt/blob/master/admin/schema.php#L591 and
https://github.com/mantisbt/mantisbt/blob/master/core/install_helper_functions_api.php
---
This email is free from viruses and malware because avast! Antivirus protection is active.
http://www.avast.com
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
mantisbt-dev mailing list
https://lists.sourceforge.net/lists/listinfo/mantisbt-dev
--
AlainD.
Thomas Koch
2014-06-05 18:58:29 UTC
Permalink
The product backlog site always redirects me to the java install site from
oracle. Does your plugin require java on the client?

We've developed a plugin that allows only the maintenance of a backlog by
dragging and dropping user stories:

https://github.com/comsolit/ComsolitBacklog

Maybe you'd like to integrate our plugin to avoid the java dependency?

Regards, Thomas Koch

Loading...